CX2: Avoid jumpiness when header becomes sticky
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pginer-WMF
	Feb 28 2018, 12:19 PM

Description

Currently the transition between sticky/non-sticky when scrolling is a bit jumpy for the header as illustrated in this animation.

Normally this is caused by the fact that the part that becomes sticky gets removed from the rest of the page making it move up. One way to compensate that is to add some extra margin/padding to the underlying page as the header becomes sticky. If such margin is closer to the same size as the header that becomes sticky, the jump would be avoided.

This ticket is a follow-up of the work done in T186874: Adjust the styling of the title and personal headers in the translation editor

Details

	Subject	Repo	Branch	Lines +/-
	Improve sticky behavior accuracy	mediawiki/extensions/ContentTranslation	master	+25 -15

Customize query in gerrit

Related Objects

Mentioned In: T186874: Adjust the styling of the title and personal headers in the translation editor
Mentioned Here: T186874: Adjust the styling of the title and personal headers in the translation editor

Event Timeline

Pginer-WMF created this task.Feb 28 2018, 12:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2018, 12:19 PM

Pginer-WMF triaged this task as Medium priority.Feb 28 2018, 12:19 PM

Pginer-WMF mentioned this in T186874: Adjust the styling of the title and personal headers in the translation editor.

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.

Change 415195 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Improve sticky behavior accuracy

https://gerrit.wikimedia.org/r/415195

gerritbot added a project: Patch-For-Review.Feb 28 2018, 1:04 PM

• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.Feb 28 2018, 1:04 PM

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-2018-Jan-Mar board.

There was already a patch for dealing with jumpiness. I have connected this ticket now. We agreed that https://gerrit.wikimedia.org/r/#/c/413695/ should be merged as is, and improved later by me, not to block other patches. That way we got imperfect stickiness.

Thanks for creating the ticket.

Nikerabbit removed a project: Patch-For-Review.Feb 28 2018, 1:52 PM

Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.

Change 415195 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Improve sticky behavior accuracy

https://gerrit.wikimedia.org/r/415195

• Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 28 2018, 4:10 PM