-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix channelHandler not sharable #2258
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2258 +/- ##
==========================================
Coverage 50.11% 50.11%
Complexity 2662 2662
==========================================
Files 518 518
Lines 17030 17030
Branches 2061 2061
==========================================
Hits 8534 8534
Misses 7689 7689
Partials 807 807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
io.seata.core.rpc.netty.AbstractRpcRemotingClient$ClientHandler is not a @sharable handler, so can't be added or removed multiple times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix channelHandler not sharable
such as the reconnect scene
Ⅱ. Does this pull request fix one issue?
fix #2256
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews