(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Responsive Dialog removes scroll after resize #584

Closed
2 tasks
AlexXanderGrib opened this issue May 31, 2024 · 1 comment
Closed
2 tasks

[Bug]: Responsive Dialog removes scroll after resize #584

AlexXanderGrib opened this issue May 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@AlexXanderGrib
Copy link

Reproduction

https://www.shadcn-vue.com/docs/components/drawer.html

Describe the bug

Reproduction steps

  1. Open https://www.shadcn-vue.com/docs/components/drawer.html
  2. Scroll to Responsive Dialog
  3. Open devtools, resize window to width 500px
  4. Click "Edit profile"
  5. Resize window to width 800px
  6. Close dialog
  7. Scroll is gone

Simple fix

watch(isOpen, open => {
  if (!open) {
    document.body.removeAttribute('style');
  }
});

Related

radix-vue/vaul-vue#51

System Info

System:
    OS: Linux 6.8 Ubuntu 24.04 LTS 24.04 LTS (Noble Numbat)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz
    Memory: 3.71 GB / 15.41 GB
    Container: Yes
    Shell: 5.2.21 - /bin/bash
  Binaries:
    Node: 20.5.1 - /usr/bin/node
    Yarn: 3.6.1 - /usr/bin/yarn
    npm: 10.2.5 - /usr/bin/npm
    pnpm: 8.15.1 - /usr/bin/pnpm
    bun: 1.0.0 - ~/.bun/bin/bun
  Browsers:
    Chrome: 125.0.6422.112

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@AlexXanderGrib AlexXanderGrib added the bug Something isn't working label May 31, 2024
@zernonia
Copy link
Member

Issue should be fixed in https://github.com/radix-vue/vaul-vue/releases/tag/vaul-vue%400.2.0 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexXanderGrib @zernonia