(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild target: User-Agent not working #848

Open
bubbajoe opened this issue Jul 1, 2024 · 4 comments
Open

esbuild target: User-Agent not working #848

bubbajoe opened this issue Jul 1, 2024 · 4 comments

Comments

@bubbajoe
Copy link
bubbajoe commented Jul 1, 2024 •
edited
Loading

Getting the target via the query params seems to work...
curl https://esm.sh/yaml@2.4.5\?target\=es2015

however, using the user agent does not seem to work
curl https://esm.sh/yaml@2.4.5 -H User-Agent:esm/es2015

Additionally, on the esm.sh website, it mentions
By default, esm.sh checks the User-Agent header to determine the build target.

but doesn't mention how it does that, it would be nice to mention how this works, I had to check the code and still didn't work.
@ije
Copy link
Member
ije commented Jul 1, 2024

there are lot of changes i didn't deploy to the production yet, including support of User-Agent:esm/es20xx

@bubbajoe
Copy link
Author
bubbajoe commented Jul 2, 2024 •
edited
Loading

Sorry I am confused, why was the esm/es20xx change just removed?

image

@ije
Copy link
Member
ije commented Jul 2, 2024

this is introduced in v136, currently production is v135

@bubbajoe
Copy link
Author
bubbajoe commented Jul 2, 2024

Thanks, when is the next planned release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ije @bubbajoe