(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@changesets/cli: Private package should be ignored from CHANGELOG.md #1093

Open
unional opened this issue Feb 18, 2023 · 5 comments
Open

@changesets/cli: Private package should be ignored from CHANGELOG.md #1093

unional opened this issue Feb 18, 2023 · 5 comments

Comments

@unional
Copy link
unional commented Feb 18, 2023

Problem

clibuilder/clibuilder#459

In the above example, the fixture-* package are all private packages without version and with private: true in their package.json.

Currently, they were and their CHANGELOG.md are generated:

https://github.com/unional/clibuilder/blob/main/packages/clibuilder/fixtures/has-dot-js-config/CHANGELOG.md

Proposed solution

These packages should not be included in the CHANGELOG.md generation.

@satya164
Copy link
satya164 commented Mar 8, 2023

Seems if I add the package names to ignore entry in the config then the changelogs aren't generated. Though I'd expect private to behave similarly since docs say to avoid ignore and use private: true instead.

@e110c0
Copy link
e110c0 commented Mar 30, 2023

I ran into a similar issue: even though an internal package in a mono repo is set private: true, I can select it when running changeset. If I add it to the ignore array, all works as expected, but according to the documentation this should not be used permanently.

@unional
Copy link
Author
unional commented Apr 29, 2023

btw, if you try to use ignore to workaround this, it doesn't work.
I run into this:

🦋  error ValidationError: Some errors occurred when validating the changesets config:
🦋  error The package "clibuilder" depends on the ignored package "cjs-plugin", but "clibuilder" is not being ignored. Please add "clibuilder" to the `ignore` option.

Because I'm adding the test package (cjs-plugin in this case) as devDependencies.

@enisdenjo
Copy link

Any news here? This issue can lead to congested changelogs when you have many private workspaces.

@jakebailey
Copy link
Contributor

If you set this in your config:

  "privatePackages": {
    "tag": false,
    "version": false
  }

Tags, version bumps, and changelogs will all not be produced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants