(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect Ratio applied wrong with MKV Crop value #13625

Open
vslmc opened this issue Mar 3, 2024 · 3 comments
Open

Aspect Ratio applied wrong with MKV Crop value #13625

vslmc opened this issue Mar 3, 2024 · 3 comments

Comments

@vslmc
Copy link
vslmc commented Mar 3, 2024

Important Information

Provide following Information:

  • mpv-x86_64-v3-20240301-git-8ba6d8f
  • Windows 11 23H2 26020.1000

Reproduction steps

Add mkv container crop values on e.g. 4:3 PAR videos (Crop = 10,2,8,4)

Expected behavior

Cropping after aspect ratio correction is applied
720x576 SAR > 768x576 PAR > 750x570 Crop

Actual behavior

720x576 SAR > 702x570 Crop > 736x570

Addional mpv reports a crop of X=10, Y=2 instead of 10,2,8,4 (but this is only a ui problem)

Sample files

Original

Bug

Correct

Sample Video
video.zip
@Dudemanguy
Copy link
Member

@kasper93 probably won't like this but maybe there should be an option for when the crop gets applied.

@kasper93
Copy link
Contributor
kasper93 commented Mar 3, 2024

720x576 SAR > 702x570 Crop > 736x570

Can you explain how you arrived at this? Post the log and retest with --no-config.

@vslmc
Copy link
Author
vslmc commented Mar 3, 2024

720x576 SAR > 702x570 Crop > 736x570

Can you explain how you arrived at this? Post the log and retest with --no-config.

Testing it , I can say there is no problem with no-config. Also after some investigation I found the problem is this line in my config file:
vf=format=fmt=nv24:primaries=dci-p3:convert=yes
Removing this line results in the correct output of 748x570

(I will add the log anyway)
log.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kasper93 @Dudemanguy @vslmc