-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv keeps exiting fullscreen after running skip-intro.lua script #13530
Comments
You need to generate a log file when actually triggering the issue, otherwise, nothing interesting will be in it. Are you on wayland, by any chance? There were a number of wayland-specific commits last week. |
Here is the log file with tab pressed: Command used:
Yes I am. Hyprland to be specific. |
Cannot reproduce on current git master mpv with The log indicates that fullscreen is never set by mpv itself so I think you have custom window rules in Hyprland. You should also upload the log with |
I can reproduce on hyprland. It's caused by 62a0292. The reason is because the vf filter causes a color change which does a reconfig. This did not happen before. I think this is still a hyprland bug however. The wayland backend still correctly sets |
I have found the problem. mpv Command Used
As Custom ConfigFor the initial tests I left sway and hyprland with my custom config. Single Monitor (1)
Multi Monitor (2 or more)
hyprland-git + mpv-git + custom config = can reproduce Default ConfigFound here: https://github.com/hyprwm/Hyprland/blob/main/example/hyprland.conf I then moved onto using the default config for hyprland and didn't test with sway any further. Single Monitor (1)
Multi Monitor (2 or more)
hyprland-git + mpv-git + default config = cannot reproduce With the issue not happening with the default config on either mpv or mpv-git, I went through the default settings and replaced each setting until I found the problem. The ProblemWhen I moved to hyprland the other day I was getting an error that wouldn't go away unless a windowrule was removed. That being this:
Re-adding this back into my config no longer gives me the error in hyprland, but is also the setting stopping mpv-git from going windowed. Although with the setting removed mpv doesn't have this issue. This still looks to me like an mpv-git problem, as hyprland just provides a patch/fix for applications that don't want to play nice with hyprland. Log FileRunning this command looks to give me the same output as not having
Even though that's the case I've copied as much as the terminal has given me to a file for you. hyprland-git
mpv-git
mpv
|
TL;DRIf you have Hyperland, mpv, skip-intro script and experience it - add |
Important Information
paru
from the aur packagempv-git
In the video you'll see when the opening starts I press "Tab" to skip forward, it skips forward but causes mpv to go windowed. To tell that it's windowed you can see the window border and waybar bar on the left.
mpv --no-config --script=~/.config/mpv/scripts/skip-intro.lua
unwanted-windowed-mode.mp4
Reproduction steps
skip-intro.lua
script from https://github.com/rui-ddc/skip-intro into your mpv scripts folder.or use this command to run the script from the downloads folder.:
Expected behaviour
The
extra/mpv 1:0.37.0-2
package on arch does the expected behaviour of when you press tab mpv doesn't go windowed when using theskip-intro.lua
script.mpv-git
doesn't do this.Actual behaviour
When pressing tab the
skip-intro.lua
script causes the mpv window to go from fullscreen to windowed.Log file
Command used:
mpv --no-config --script=~/.config/mpv/scripts/skip-intro.lua --log-file=output.txt
output.txt
Sample files
skip-intro.lua.txt
The text was updated successfully, but these errors were encountered: