(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PQ is not properly tonemapped to lower max brightness of HDR screens with vo=gpu-next #13592

Open
erazortt opened this issue Feb 28, 2024 · 2 comments

Comments

@erazortt
Copy link
erazortt commented Feb 28, 2024

Important Information

Provide following Information:

  • mpv version: mpv-dev-x86_64-v3-20240218-git-bd5b80b
  • Platform and Version: Windows 11
  • Source of the mpv binary: https://sourceforge.net/projects/mpv-player-windows/files/
  • If known which version of mpv introduced the problem: was there all the time, going back two years at least.
  • GPU model, driver and version: RTX 3000, Nvidia driver 551.61 but all back to 472 have been tested
  • Possible screenshot or video of visual glitches, are attached

Reproduction steps

Setup the config file:
vo=gpu-next
target-colorspace-hint=yes
target-prim=bt.2020
target-trc=pq
hdr-compute-peak=no
target-peak=500

For target-peak use the value matching to your HDR display. It must be a HDR display!

Play back the attached calibration clip: ColorSteps_BT.2100_PQ.mkv

Expected behavior

While playing the attached calibration clip, the brightness of each color strip should increase up to the 235 value and not increase any further above that. Look at the attached expectation.png for reference.

Actual behavior

Look at the attached actual_photo.jpg, which was taken with an external device. The color field where the mouse cursor is, should not have been different from the two color fields left and right.
I also attached two screenshots: One was taken in jpg where this issue is visible and the other one was taking in avif where, interestingly, the issue is not visible.

Log file

is attached.

Sample files

directly attached are: expectation.png, actual_screenshot.jpg, log.txt
attached in the zip are: actual_screenshot.avif and ColorSteps_BT.2100_PQ.mkv

expectation.png:
expectation
actual_photo.jpg:
actual_photo
actual_screenshot.jpg:
actual_screenshot
additionalFiles.zip
log.txt

@erazortt erazortt changed the title PQ is not properly tonemapped to lower max brightness of HDR screens PQ is not properly tonemapped to lower max brightness of HDR screens with vo=gpu-next Feb 28, 2024
@quietvoid
Copy link
Contributor

This seems caused by most gamut mapping modes except clip and saturation.

@erazortt
Copy link
Author
erazortt commented Mar 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants