Issues related to the wikimedia/assert (formerly mediawiki/assert) composer library.
Details
Details
Mar 26 2022
Mar 26 2022
DannyS712 added a comment to T250776: The $description in the Wikimedia\Assert methods should be callable|string.
@param string|callable will make phan think that it has to be a callable, and if its a string it should be a function name, which would break all existing uses and require suppressing the failures in each place, which I don't think is worth it. Perhaps wait until that is fixed in phan. See T297352: PhanUndeclaredFunctionInCallable triggers for callable|string types and upstream https://github.com/phan/phan/issues/1648
Mar 25 2022
Mar 25 2022
Reedy added a comment to T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
With https://gerrit.wikimedia.org/r/c/css-sanitizer/+/562681 merged, css-sanitizer is probably due a major release.
Mar 25 2022, 3:59 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
Mar 20 2022
Mar 20 2022
gerritbot added a comment to T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
Change 770925 merged by jenkins-bot:
[mediawiki/libs/Timestamp@master] Release v4.0.0
Mar 20 2022, 2:46 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
gerritbot added a comment to T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
Change 771888 merged by jenkins-bot:
[mediawiki/libs/ScopedCallback@master] build: Sync with latest cookiecutter boilerplate
Mar 20 2022, 1:16 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
Mar 18 2022
Mar 18 2022
gerritbot added a comment to T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
Change 771888 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/libs/ScopedCallback@master] build: Sync with latest cookiecutter boilerplate
Mar 18 2022, 1:56 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
Mar 16 2022
Mar 16 2022
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 771322 merged by jenkins-bot:
[purtle@master] Fix several type hints
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 771322 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[purtle@master] Fix several type hints
Mar 15 2022
Mar 15 2022
Reedy added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Hopefully that's them all!
Jdforrester-WMF closed T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup, a subtask of T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021), as Resolved.
Mar 15 2022, 5:36 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770664 merged by jenkins-bot:
[php-session-serializer@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770667 merged by jenkins-bot:
[mediawiki/libs/XMPReader@master] Add phan
Jdforrester-WMF updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Jdforrester-WMF updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770947 merged by jenkins-bot:
[wikimedia/lucene-explain-parser@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770948 merged by jenkins-bot:
[wikimedia/textcat@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770947 had a related patch set uploaded (by Reedy; author: Reedy):
[wikimedia/lucene-explain-parser@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770950 had a related patch set uploaded (by Reedy; author: Reedy):
[purtle@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770948 had a related patch set uploaded (by Reedy; author: Reedy):
[wikimedia/textcat@master] Add phan
gerritbot added a comment to T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
Change 770925 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/libs/Timestamp@master] Release v4.0.0
Mar 15 2022, 3:09 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
Zabe updated the task description for T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).
Mar 15 2022, 2:59 PM · Patch-For-Review, Purtle, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Technical-Debt, WrappedString, WaitConditionLoop, utfnormal, ToolforgeBundle, Wikimedia-Timestamp, FR-Smashpig, Shellbox, ScopedCallback, RunningStat, RemexHtml, php-session-serializer, ObjectFactory, NormalizedException, IPUtils, IPSet, HtmlFormatter, Equivset, css-sanitizer, CommonPasswords, base_convert, at-ease, MediaWiki-libs-Assert, Arc-Lamp, AhoCorasick, Release, Performance-Team, WMF-General-or-Unknown, Librarization
Reedy updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770668 merged by jenkins-bot:
[utfnormal@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770670 merged by jenkins-bot:
[mediawiki/libs/Equivset@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770918 merged by jenkins-bot:
[mediawiki/libs/CommonPasswords@master] Add phan (take 2)
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770669 merged by jenkins-bot:
[HtmlFormatter@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770918 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/libs/CommonPasswords@master] Add phan (take 2)
Reedy updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770650 merged by jenkins-bot:
[RunningStat@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770665 merged by jenkins-bot:
[base-convert@master] Add phan
Reedy updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Reedy updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770670 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/libs/Equivset@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770657 merged by jenkins-bot:
[mediawiki/libs/ScopedCallback@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770669 had a related patch set uploaded (by Reedy; author: Reedy):
[HtmlFormatter@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770668 had a related patch set uploaded (by Reedy; author: Reedy):
[utfnormal@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770667 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/libs/XMPReader@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770656 merged by jenkins-bot:
[RelPath@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770665 had a related patch set uploaded (by Reedy; author: Reedy):
[base-convert@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770652 merged by jenkins-bot:
[at-ease@master] Add phan
Jdforrester-WMF updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770664 had a related patch set uploaded (by Reedy; author: Reedy):
[php-session-serializer@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770657 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/libs/ScopedCallback@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770656 had a related patch set uploaded (by Reedy; author: Reedy):
[RelPath@master] Add phan
gerritbot added a comment to T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Change 770651 merged by jenkins-bot:
[mediawiki/libs/Assert@master] Add phan
Jdforrester-WMF updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.
Jdforrester-WMF updated the task description for T303786: Add phan to Wikimedia-authored PHP libraries that don't have phan setup.